Maintenance controller #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add additional helper methods - Modify some existing functions to accept k8sclient and update object in api. Signed-off-by: adrianc <[email protected]>
add additional helpers for tests to be used in subsequent commits Signed-off-by: adrianc <[email protected]>
Signed-off-by: adrianc <[email protected]>
Pull Request Test Coverage Report for Build 10301427801Details
💛 - Coveralls |
ykulazhenkov
reviewed
Aug 8, 2024
cordon package handles operation needed to be perfomed for NodeMaintenance in cordon state. Signed-off-by: adrianc <[email protected]>
podcompletion package handles operation that need to be performed for NodeMaintenance in WaitForPodCompletion state. Signed-off-by: adrianc <[email protected]>
Add WaitForCompletion field in status to list pods NodeMaintenance is waiting to be completed. Signed-off-by: adrianc <[email protected]>
update scheduler controller to use new APIs from k8sutils package. Signed-off-by: adrianc <[email protected]>
this is a partial implementation of the nodemaintenance controller. Additional logic which was added: - handle scheduled state for node maintenance - handle cordon state for node maintenance - handle waitForPodCompletion state for node maintenance - Handle ready state for node maintenance - support deletion flow in each of the above step - implement new predicate to handle enqueue of events on node maintenance creation, change in Ready condition and deletion. use it when setting up reconciler with manager. implementation leverages cordon and podcompletion pacakges introduced in earlier commits Signed-off-by: adrianc <[email protected]>
- properly create NodeMaintenanceReconciler with all required fields - update cach indexer to support listing pods by spec.nodeName to be used by podcompletion package - update rbac yaml Signed-off-by: adrianc <[email protected]>
Signed-off-by: adrianc <[email protected]>
adrianchiris
force-pushed
the
maintenance-controller
branch
from
b478f03 to
507d331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to individual commits for context.